Skip to content

Added ecc/ecc-export-Qx-Qy example program#223

Merged
kaleb-himes merged 3 commits intowolfSSL:masterfrom
danielinux:ecc-export-qx-qy
Jul 30, 2020
Merged

Added ecc/ecc-export-Qx-Qy example program#223
kaleb-himes merged 3 commits intowolfSSL:masterfrom
danielinux:ecc-export-qx-qy

Conversation

@danielinux
Copy link
Copy Markdown
Member

Example on how to convert a ASN.1 ECC key into [Qx,Qy] raw form, used e.g. in wolfBoot.

Minor extra change: added -pthread to the LDFLAGS otherwise ecc-stack example in the same directory would not link (gcc9.2.1/GNU-Linux).

Copy link
Copy Markdown
Contributor

@kaleb-himes kaleb-himes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Daniele,

Thanks! Just a few things:

@danielinux
Copy link
Copy Markdown
Member Author

Kaleb,
Thank you!

Added description in README.md and ifdef guards as suggested.

@kaleb-himes kaleb-himes self-requested a review July 30, 2020 14:24
Copy link
Copy Markdown
Contributor

@kaleb-himes kaleb-himes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Daniele, looks great! I would note only one minor thing we can improve in a future PR, you have the POINT_SIZE set to 32 which only allows this app to work with the following ECC key sizes:

112, 128, 160, 192, 224, 239, 256.

I tested with key sizes 320, 384, 512, and 521 but all failed. If we set POINT_SIZE to 69 it can be used with any supported ECC key size between 112 and 521!

Thanks for the great example!

  • KH

@kaleb-himes kaleb-himes merged commit 5a0c1bd into wolfSSL:master Jul 30, 2020
yota22721 pushed a commit to yota22721/wolfssl-examples that referenced this pull request Jan 25, 2025
Added ecc/ecc-export-Qx-Qy example program
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants