Added ecc/ecc-export-Qx-Qy example program#223
Merged
kaleb-himes merged 3 commits intowolfSSL:masterfrom Jul 30, 2020
Merged
Conversation
kaleb-himes
requested changes
Jul 29, 2020
Contributor
kaleb-himes
left a comment
There was a problem hiding this comment.
Daniele,
Thanks! Just a few things:
- Can you add a
ecc-export-Qx-Qysection to the README.md (Example: https://github.com/danielinux/wolfssl-examples/tree/ecc-export-qx-qy/ecc#ecc-key-decode)? - Can you add a macro guard such that if appropriate configuration is not used the example will still build and run simply outputting the line "please configure wolfSSL with --enable-xxx and try again (Example: https://github.com/danielinux/wolfssl-examples/blob/ecc-export-qx-qy/ecc/ecc-verify.c#L115)
Member
Author
|
Kaleb, Added description in README.md and ifdef guards as suggested. |
kaleb-himes
approved these changes
Jul 30, 2020
Contributor
kaleb-himes
left a comment
There was a problem hiding this comment.
Thanks Daniele, looks great! I would note only one minor thing we can improve in a future PR, you have the POINT_SIZE set to 32 which only allows this app to work with the following ECC key sizes:
112, 128, 160, 192, 224, 239, 256.
I tested with key sizes 320, 384, 512, and 521 but all failed. If we set POINT_SIZE to 69 it can be used with any supported ECC key size between 112 and 521!
Thanks for the great example!
- KH
yota22721
pushed a commit
to yota22721/wolfssl-examples
that referenced
this pull request
Jan 25, 2025
Added ecc/ecc-export-Qx-Qy example program
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example on how to convert a ASN.1 ECC key into [Qx,Qy] raw form, used e.g. in wolfBoot.
Minor extra change: added -pthread to the LDFLAGS otherwise
ecc-stackexample in the same directory would not link (gcc9.2.1/GNU-Linux).