Fixes issue with uninitialized caKey#277
Merged
anhu merged 3 commits intowolfSSL:masterfrom Nov 30, 2021
Merged
Conversation
anhu
requested changes
Nov 29, 2021
Member
anhu
left a comment
anhu
left a comment
There was a problem hiding this comment.
initCaKey declaration and usage needs to be guarded by HAVE_ECC since caKey's declaration is guarded by HAVE_ECC.
Member
|
Same goes for |
…uplicate with_altnames and combined into existing example.
anhu
requested changes
Nov 29, 2021
Member
anhu
left a comment
anhu
left a comment
There was a problem hiding this comment.
Nice! I've left a couple of comments. Also, I think the description of this PR no longer fits.
| const char* csrPemFile = argv[2]; | ||
| const char* caCertPemFile = argv[3]; | ||
| const char* caKeyPemFile = argv[4]; | ||
| const char* typeStr = "ecc"; |
Member
There was a problem hiding this comment.
logic on line 86 is no longer required.
| static void usage(void) | ||
| { | ||
| printf("Usage: ./csr_sign [type] [csr.pem] [ca-cert.pem] [ca-key.pem]\n"); | ||
| printf("Usage: ./csr_sign [csr.pem] [ca-cert.pem] [ca-key.pem]\n"); |
Member
There was a problem hiding this comment.
I'm not positive about this, but I think square brackets means its optional. But the way the code works below, these are not optional args.
yota22721
pushed a commit
to yota22721/wolfssl-examples
that referenced
this pull request
Jan 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue with uninitialized
caKeyfound with valgrind reported in ZD 13212.