Tls client: fix bad comparison for non-blocking shutdown call.#327
Merged
kareem-wolfssl merged 1 commit intowolfSSL:masterfrom Jul 20, 2022
Merged
Conversation
Member
|
Hi @JamesMenetrey , you are correct about this bug. We will treat as a bug report and fix. Assigning ticket to @kareem-wolfssl. Thanks, David Garske, wolfSSL |
kareem-wolfssl
approved these changes
Jul 20, 2022
Contributor
kareem-wolfssl
left a comment
kareem-wolfssl
left a comment
There was a problem hiding this comment.
Thanks for this patch, great catch.
yota22721
pushed a commit
to yota22721/wolfssl-examples
that referenced
this pull request
Jan 25, 2025
…tdown Tls client: fix bad comparison for non-blocking shutdown call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear WolfSSL developers,
After reading your example of the non-blocking TLS client, I think the loop's condition for the TLS shutdown is incorrect. The variable
errmust be compared, instead ofretdirectly.I am providing this PR to fix this issue.
Cheers,
Jämes