Skip to content

add cmake example tie in#358

Merged
dgarske merged 2 commits intowolfSSL:masterfrom
JacobBarthelmeh:cmake
Dec 29, 2022
Merged

add cmake example tie in#358
dgarske merged 2 commits intowolfSSL:masterfrom
JacobBarthelmeh:cmake

Conversation

@JacobBarthelmeh
Copy link
Copy Markdown
Contributor

ZD14997

Copy link
Copy Markdown
Member

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super useful! Thanks.

Works as described, but do get a code warning:

[ 98%] Building C object CMakeFiles/hash.dir/myApp.c.o
/Users/davidgarske/GitHub/wolfssl-examples/cmake/myApp.c:40:37: warning: passing 'char *' to parameter of type 'const byte *' (aka 'const unsigned char *') converts between pointers to integer types with different sign [-Wpointer-sign]
        ret = wc_Sha256Update(&sha, argv[1], (word32)XSTRLEN(argv[1]));
                                    ^~~~~~~
/Users/davidgarske/GitHub/wolfssl-examples/cmake/wolfssl/wolfssl/wolfcrypt/sha256.h:242:61: note: passing argument to parameter 'data' here
WOLFSSL_API int wc_Sha256Update(wc_Sha256* sha, const byte* data, word32 len);
                                                            ^
1 warning generated.

@dgarske dgarske assigned JacobBarthelmeh and unassigned dgarske Dec 29, 2022
@JacobBarthelmeh
Copy link
Copy Markdown
Contributor Author

Thanks for the review! Added a cast and Init/Cleanup functions.

@dgarske dgarske merged commit 7cd33a3 into wolfSSL:master Dec 29, 2022
yota22721 pushed a commit to yota22721/wolfssl-examples that referenced this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants