add cmake example tie in#358
Merged
dgarske merged 2 commits intowolfSSL:masterfrom Dec 29, 2022
Merged
Conversation
dgarske
requested changes
Dec 29, 2022
Member
dgarske
left a comment
There was a problem hiding this comment.
This is super useful! Thanks.
Works as described, but do get a code warning:
[ 98%] Building C object CMakeFiles/hash.dir/myApp.c.o
/Users/davidgarske/GitHub/wolfssl-examples/cmake/myApp.c:40:37: warning: passing 'char *' to parameter of type 'const byte *' (aka 'const unsigned char *') converts between pointers to integer types with different sign [-Wpointer-sign]
ret = wc_Sha256Update(&sha, argv[1], (word32)XSTRLEN(argv[1]));
^~~~~~~
/Users/davidgarske/GitHub/wolfssl-examples/cmake/wolfssl/wolfssl/wolfcrypt/sha256.h:242:61: note: passing argument to parameter 'data' here
WOLFSSL_API int wc_Sha256Update(wc_Sha256* sha, const byte* data, word32 len);
^
1 warning generated.
Contributor
Author
|
Thanks for the review! Added a cast and Init/Cleanup functions. |
dgarske
approved these changes
Dec 29, 2022
yota22721
pushed a commit
to yota22721/wolfssl-examples
that referenced
this pull request
Jan 25, 2025
add cmake example tie in
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZD14997