dtls: server fixes#431
Merged
philljj merged 2 commits intowolfSSL:masterfrom Apr 11, 2024
Merged
Conversation
avoid calling wolfSSL_Accept() on a socket while peer is not set, otherwise the SSL objects may sends messages to the wrong peer. Also, use a "connected" udp-socket to allow receiving packets from other peers in another socket bound to the same local address.
Contributor
|
Thank you, this is a definite improvement and more robust. |
philljj
requested changes
Apr 5, 2024
Contributor
philljj
left a comment
philljj
left a comment
There was a problem hiding this comment.
Looks good. Just found one logging message that needs correcting.
| ret = wolfSSL_set_fd(args[i].ssl, args[i].activefd); | ||
| if (ret != SSL_SUCCESS) { | ||
| printf("error: wolfSSL_accept returned %d\n", ret); | ||
| printf("error: wolfSSL_set_dtls_fd_connected: %d\n", ret); |
Contributor
There was a problem hiding this comment.
The error message error: wolfSSL_set_dtls_fd_connected: doesn't match the function called wolfSSL_set_fd().
rizlik
force-pushed
the
dtls-server-fixes
branch
from
8b93f53 to
ae0372d
Compare
Contributor
Author
|
fixed error printf and improved comments |
philljj
approved these changes
Apr 11, 2024
yota22721
pushed a commit
to yota22721/wolfssl-examples
that referenced
this pull request
Jan 25, 2025
dtls: server fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.