Skip to content

Conversation

@anhu
Copy link
Member

@anhu anhu commented Sep 12, 2024

No description provided.

@anhu anhu self-assigned this Sep 12, 2024
@anhu anhu force-pushed the client-tls-pkcs11 branch from 076cc57 to 653a2a9 Compare September 12, 2024 18:45
@anhu anhu requested a review from wolfSSL-Bot September 12, 2024 18:45
@anhu anhu assigned wolfSSL-Bot and unassigned anhu Sep 12, 2024
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warnings on build:

client-tls-pkcs11-ecc.c: In function ‘client_tls’:
client-tls-pkcs11-ecc.c:49:24: warning: unused variable ‘shutdown’ [-Wunused-variable]
   49 |     int                shutdown = 0;
      |                        ^~~~~~~~
client-tls-pkcs11-ecc.c:46:24: warning: unused variable ‘size’ [-Wunused-variable]
   46 |     socklen_t          size = sizeof(servAddr);
      |                        ^~~~
gcc -o client-tls-pkcs11-rsa client-tls-pkcs11-rsa.c -Wall -I/usr/local/include -Os -L/usr/local/lib -lm -lwolfssl
client-tls-pkcs11-rsa.c: In function ‘client_tls’:
client-tls-pkcs11-rsa.c:49:24: warning: unused variable ‘shutdown’ [-Wunused-variable]
   49 |     int                shutdown = 0;
      |                        ^~~~~~~~
client-tls-pkcs11-rsa.c:46:24: warning: unused variable ‘size’ [-Wunused-variable]
   46 |     socklen_t          size = sizeof(servAddr);
      |                        ^~~~

When updating the pkcs11 examples please touch up all the cases of :

 1125 |     unsigned char exp_sha512[SHA512_DIGEST_SIZE] = {
      |                              ^~~~~~~~~~~~~~~~~~
      |                              WC_SHA512_DIGEST_SIZE

@anhu anhu assigned JacobBarthelmeh and unassigned anhu Sep 20, 2024
@JacobBarthelmeh
Copy link
Contributor

$ make
gcc -o client-tls-pkcs11 client-tls-pkcs11.c -Wall -I/usr/local/include -Os -L/usr/local/lib -lm -lwolfssl
client-tls-pkcs11.c: In function ‘client_tls’:
client-tls-pkcs11.c:107:17: error: ‘CA_FILE’ undeclared (first use in this function); did you mean ‘AF_FILE’?
  107 |                 CA_FILE);
      |                 ^~~~~~~
      |                 AF_FILE
client-tls-pkcs11.c:107:17: note: each undeclared identifier is reported only once for each function it appears in
client-tls-pkcs11.c: In function ‘main’:
client-tls-pkcs11.c:200:21: error: expected ‘;’ before ‘library’
  200 |     cacert = argv[1]
      |                     ^
      |                     ;
  201 |     library = argv[2];
      |     ~~~~~~~          
make: *** [Makefile:33: client-tls-pkcs11] Error 1

Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address errors on make.

@anhu anhu assigned JacobBarthelmeh and wolfSSL-Bot and unassigned anhu Sep 26, 2024
@JacobBarthelmeh JacobBarthelmeh merged commit 2f67b03 into wolfSSL:master Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants