Skip to content

New MAXQ 1065/1080 LWIP example.#462

Merged
JacobBarthelmeh merged 4 commits intowolfSSL:masterfrom
anhu:maxq_lwip
Sep 24, 2024
Merged

New MAXQ 1065/1080 LWIP example.#462
JacobBarthelmeh merged 4 commits intowolfSSL:masterfrom
anhu:maxq_lwip

Conversation

@anhu
Copy link
Copy Markdown
Member

@anhu anhu commented Sep 18, 2024

No description provided.

Comment thread maxq10xx/wolfssl-lwip-client.c Outdated
#else

#if defined (TEST_RSA)
ret = wolfSSL_CTX_use_PrivateKey_buffer(ctx, rsa_key_der_2048,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent for readability

Comment thread maxq10xx/wolfssl-lwip-client.c
Comment thread maxq10xx/wolfssl-lwip-client.c Outdated
/* Print to stdout any data the server sends */
MXC_DEBUG_MSG("Server: %s\n", buff);
return ret;
// ret = 0; /* success */
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove double comment style here

Comment thread maxq10xx/wolfssl-lwip-client.c Outdated

if (sockfd >= 0)
lwip_close(sockfd);
while(lwip_read(sockfd,lBuff, SOCKET_BUF_SIZE) > 0);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this after the close of the socket? Is it to flush it after the socket has already been closed? Nit pick: there is no space after first ,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for feedback from someone else.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According the feedback received, this is correct. The socket is being flushed.

Comment thread maxq10xx/wolfssl-lwip-client.c
Comment thread maxq10xx/README.md

This example shows how to write a simple TLS client that uses the features
of the Analog Devices MAXQ1065 and 1080 USS. Note that this is not a
stand-alone application. This is part of an example that can be found in the
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...part of an example that can be found in the SDK supplied by Analog Devices.

Is this example our IP? Written by us. Please add how someone would go about compiling the example. i.e. if should download the SDK then add wolfssl-lwip-client.c to a specific location and build.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not addressed yet. Waiting for feedback from someone else.

@JacobBarthelmeh JacobBarthelmeh assigned anhu and unassigned wolfSSL-Bot Sep 18, 2024
@anhu
Copy link
Copy Markdown
Member Author

anhu commented Sep 20, 2024

All issues except 2 have been addressed.

@anhu anhu assigned JacobBarthelmeh and wolfSSL-Bot and unassigned anhu Sep 24, 2024
@JacobBarthelmeh JacobBarthelmeh merged commit f935fd0 into wolfSSL:master Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants