Skip to content

Add a minimal example for ecc verify#571

Merged
kaleb-himes merged 1 commit intowolfSSL:masterfrom
lealem47:ecc_verify_minimal
Apr 24, 2026
Merged

Add a minimal example for ecc verify#571
kaleb-himes merged 1 commit intowolfSSL:masterfrom
lealem47:ecc_verify_minimal

Conversation

@lealem47
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 23, 2026 22:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a standalone C program demonstrating how to verify an ECDSA signature with wolfCrypt ECC APIs.

Changes:

  • Introduces a minimal ECC verify example using wc_ecc_import_x963_ex() and wc_ecc_verify_hash()
  • Adds hard-coded sample SHA-256 hash, DER signature, and X9.63 public key data
  • Includes a short-digest length guard intended to mitigate short-hash verification bypasses

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ecc/ecc-verify-minimal.c Outdated
Comment thread ecc/ecc-verify-minimal.c Outdated
Comment thread ecc/ecc-verify-minimal.c Outdated
Comment thread ecc/ecc-verify-minimal.c Outdated
@lealem47 lealem47 force-pushed the ecc_verify_minimal branch from 36397a8 to 7271cc0 Compare April 24, 2026 18:31
Copy link
Copy Markdown
Contributor

@kaleb-himes kaleb-himes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @lealem47

@kaleb-himes kaleb-himes merged commit bfdda56 into wolfSSL:master Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants