Skip to content

Found a typo in esp32_sha.c #7606

@Jreuningschererhubbell

Description

@Jreuningschererhubbell

The file wolfcrypt/src/port/Espressif/esp32_sha.c has a typo in line 1523.

SP_LOGI(TAG, "3) esp_sha_hw_unlock Lock depth @ %d = %d "

The correct function name is ESP_LOGI.

Compiling for ESP32 with the typo results in an 'implicit function declaration error':

REDACTED-PATH/wolfssl/wolfcrypt/src/port/Espressif/esp32_sha.c: In function 'esp_sha_hw_unlock':
REDACTED-PATH/wolfssl/wolfcrypt/src/port/Espressif/esp32_sha.c:1523:5: error: implicit declaration of function 'SP_LOGI'; did you mean 'ESP_LOGI'? [-Werror=implicit-function-declaration]
 1523 |     SP_LOGI(TAG, "3) esp_sha_hw_unlock Lock depth @ %d = %d "
      |     ^~~~~~~
      |     ESP_LOGI
cc1: some warnings being treated as errors

Compiling for ESP32 with the corrected function name succeeds.

I discovered this issue when I enabled WOLFSSL_ESP32_HW_LOCK_DEBUG while working with a ESP32-WROOM-32E.

Thanks!

Edit: I misspelled 'REDACTED'

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions