[Bug]: LMS verify fails for heights 15, 20, and 25 when using a 16-bit device

[seth-burchfield]

Version

5.8.2

Description

Using wolfCrypt with a 16-bit device, LMS verify is failing for the listed vector heights.

I seem to have resolved the issue locally by casting the 1 literal on this line to word32.

The project's user_settings.h file includes the following options:

#define NO_MD5
#define NO_SHA
#define NO_MD4
#define NO_DSA
#define NO_OLD_TLS
#define NO_ASN
#define WOLFSSL_OLD_OID_SUM
#define WC_NO_HARDEN
#define NO_FILESYSTEM
#define WOLFSSL_IGNORE_FILE_WARN

#define WOLFSSL_HAVE_LMS
#define WOLFSSL_WC_LMS
#define WOLFSSL_LMS_SHA256_192
#define WOLFSSL_LMS_VERIFY_ONLY
#define WOLFSSL_WC_LMS_SMALL

#define WC_16BIT_CPU
#define SIZEOF_LONG_LONG 4
#define SINGLE_THREADED
#define WOLFSSL_GENERAL_ALIGNMENT 0
#define WOLFSSL_USE_ALIGN
#define FAST_ROTATE

Reproduction steps

No response

Relevant log output

[anhu]

Excellent find @seth-burchfield . Can you let us know a bit more about what you are doing and your goals for this project?

Unfortunately I don't have a way to reproduce this as I have no 16 bit device. @SparkiDev , can you have a closer look and provide some feedback on the solution described be @seth-burchfield ?

Warm regards, Anthony

[SparkiDev]

Hi @seth-burchfield,

I've put up a PR that should fix the issue based on your findings: #9310
There are more casts that I've added and so please check that your build works with the PR.

Thanks,
Sean

[seth-burchfield]

Hello @anhu and @SparkiDev, I have tested the changes in your PR. They are building fine and resolve the issue. Thank you.

[anhu]

Closing the issue on @seth-burchfield as he has stated issue is resolved.