Merged
Conversation
…RICT_ANSI__ variant of wc_debug_trace_error_codes_enabled(), to inhibit false positive "error: ISO C forbids braced-groups within expressions" with -pedantic.
…ious initializations. wolfssl/ssl.h, examples/client/client.c, examples/server/server.c, src/bio.c, tests/api.c: add error tracing for WOLFSSL_SHUTDOWN_NOT_DONE. tests/api.c: in test_wolfSSL_read_write_ex(), use WOLFSSL_SUCCESS rather than 1 for expected-success wolfSSL_shutdown()s, and add note that the wrong value is being returned (the test currently always fails, which is masked by an always-success retval).
SparkiDev
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfssl/wolfcrypt/error-crypt.h: add__extension__to__GNUC__&&!__STRICT_ANSI__variant ofwc_debug_trace_error_codes_enabled(), to inhibit false positive "error: ISO C forbids braced-groups within expressions" with-pedantic.src/keys.candsrc/tls13.c: addWC_NO_ERR_TRACE()annotations for various initializations.wolfssl/ssl.h,examples/client/client.c,examples/server/server.c,src/bio.c,tests/api.c: add error tracing forWOLFSSL_SHUTDOWN_NOT_DONE.tests/api.c: intest_wolfSSL_read_write_ex(), useWOLFSSL_SUCCESSrather than1for expected-successwolfSSL_shutdown()s, and add note that the wrong value is being returned (the test currently always fails, which is masked by an always-success retval).wolfcrypt/src/logging.c: fix recursion inwc_backtrace_render().tested with