Skip to content

Reject negative CRL numbers when decoding#10087

Merged
douzzer merged 1 commit intowolfSSL:masterfrom
padelsbach:crl-num-negative
Mar 31, 2026
Merged

Reject negative CRL numbers when decoding#10087
douzzer merged 1 commit intowolfSSL:masterfrom
padelsbach:crl-num-negative

Conversation

@padelsbach
Copy link
Copy Markdown
Contributor

Description

Ensure negative ASN.1 integers are not allowed for CRLs (most significant bit is set in the CRL num field). Fixes an overflow which corrupts the adjacent hash field during decode.

Fixes zd21425

Testing

How did you test?

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@padelsbach padelsbach force-pushed the crl-num-negative branch 3 times, most recently from e737e3b to 1edf512 Compare March 27, 2026 18:52
Copy link
Copy Markdown

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10087

Scan targets checked: wolfcrypt-api_misuse, wolfcrypt-bugs, wolfcrypt-concurrency, wolfcrypt-portability, wolfcrypt-src

No new issues found in the changed files. ✅

@padelsbach padelsbach marked this pull request as ready for review March 30, 2026 16:45
@padelsbach
Copy link
Copy Markdown
Contributor Author

jenkins retest this please

@douzzer douzzer added For This Release Release version 5.9.1 Staged Staged for merge pending final test results and review labels Mar 30, 2026
@douzzer douzzer merged commit 1a3daf0 into wolfSSL:master Mar 31, 2026
488 of 491 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.1 Staged Staged for merge pending final test results and review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants