Skip to content

Improve QAT AES GCM tag checking #10143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobBarthelmeh merged 1 commit into from
Apr 9, 2026
+15 −2
Merged

Improve QAT AES GCM tag checking #10143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions wolfcrypt/src/port/intel/quickassist.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2214,9 +2214,7 @@ static void IntelQaSymCipherCallback(void *pCallbackTag, CpaStatus status,
int ret = ASYNC_OP_E;

(void)opData;
(void)verifyResult;
(void)pDstBuffer;
(void)operationType;

#ifdef QAT_DEBUG
printf("IntelQaSymCipherCallback: dev %p, type %d, status %d, "
Expand Down Expand Up @@ -2270,6 +2268,18 @@ static void IntelQaSymCipherCallback(void *pCallbackTag, CpaStatus status,

/* mark event result */
ret = 0; /* success */

/* check verify result for authenticated ciphers (AES-GCM).
* Note: ALGORITHM_CHAINING is only used by AES-GCM in this
* code path. For encrypt verifyResult will be CPA_TRUE. */
if (operationType == CPA_CY_SYM_OP_ALGORITHM_CHAINING &&
verifyResult == CPA_FALSE) {
/* wipe output - do not return unauthenticated plaintext */
if (dev->qat.out) {
ForceZero(dev->qat.out, dev->qat.outLen);
}
Comment thread
dgarske marked this conversation as resolved.
ret = AES_GCM_AUTH_E;
}
}
}

Expand Down Expand Up @@ -2399,6 +2409,9 @@ static int IntelQaSymCipher(WC_ASYNC_DEV* dev, byte* out, const byte* in,
setup.hashSetupData.authModeSetupData.aadLenInBytes = authInSz;

setup.digestIsAppended = CPA_TRUE;
Comment thread
dgarske marked this conversation as resolved.
if (cipherDirection == CPA_CY_SYM_CIPHER_DIRECTION_DECRYPT) {
setup.verifyDigest = CPA_TRUE;
}
}

/* open session */
Expand Down
Loading