Add BN_bn2binpad API and enable OpenVPN master CI testing#10148
Add BN_bn2binpad API and enable OpenVPN master CI testing#10148JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds OpenSSL-compatible BN_bn2binpad support to wolfSSL’s OpenSSL shim layer and updates the OpenVPN GitHub Actions workflow to test against OpenVPN master again now that the API exists.
Changes:
- Added
wolfSSL_BN_bn2binpaddeclaration +BN_bn2binpadmacro mapping. - Implemented
wolfSSL_BN_bn2binpadwith left-zero-padding semantics and size checks. - Expanded BN API tests and updated OpenVPN CI matrix to include
master.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| wolfssl/openssl/bn.h | Exposes wolfSSL_BN_bn2binpad and maps BN_bn2binpad to it. |
| src/ssl_bn.c | Implements wolfSSL_BN_bn2binpad encoding/padding behavior. |
| tests/api/test_ossl_bn.c | Adds coverage for BN_bn2binpad success/error cases. |
| .github/workflows/openvpn.yml | Re-enables testing against OpenVPN master in CI matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
julek-wolfssl
force-pushed
the
openvpn-master-bn2binpad
branch
from
d8e9584 to
312de40
Compare
julek-wolfssl
force-pushed
the
openvpn-master-bn2binpad
branch
from
312de40 to
175cdaa
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
julek-wolfssl
force-pushed
the
openvpn-master-bn2binpad
branch
from
175cdaa to
0c43158
Compare
|
@julek-wolfssl please address #10148 (review) |
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 2 total — 2 posted, 0 skipped
Posted findings
- [Low] Dead code:
numBytes < 0check can never trigger —src/ssl_bn.c:497-499 - [Medium] Missing test for
toLen == 0edge case —tests/api/test_ossl_bn.c:326-357
Review generated by Skoll via openclaw
julek-wolfssl
force-pushed
the
openvpn-master-bn2binpad
branch
from
0c43158 to
3e74f84
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
retest this please unrelated. |
|
Failures not related |
|
Retest this please Jenkins |
No description provided.