MSVC: replace UINT32_MAX with WOLFSSL_MAX_32BIT in dilithium.c#10161
Merged
padelsbach merged 1 commit intowolfSSL:masterfrom Apr 8, 2026
Merged
MSVC: replace UINT32_MAX with WOLFSSL_MAX_32BIT in dilithium.c#10161padelsbach merged 1 commit intowolfSSL:masterfrom
padelsbach merged 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates Dilithium overflow guards to use a wolfSSL-defined 32-bit maximum constant instead of UINT32_MAX, improving portability for MSVC builds.
Changes:
- Replaced
UINT32_MAXwithWOLFSSL_MAX_32BITin length overflow checks. - Kept existing overflow-avoidance logic intact while using a project-standard constant.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
retest this please |
padelsbach
approved these changes
Apr 8, 2026
Contributor
|
This is affecting wolfHSM CI. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.