ARM ASM: AES-GCM small table without NEON#10176
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Apr 12, 2026
Merged
Conversation
dgarske
reviewed
Apr 9, 2026
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 1 total — 1 posted, 0 skipped
Posted findings
- [Medium]
#elsedefines NEON macro on non-ARMASM builds —wolfcrypt/src/aes.c:7989-7992
Review generated by Skoll via openclaw
Non-neon GCM_gmult_len requires M0 which is not available with a small build. Fix to have C implementation when M0 and NEON not available.
SparkiDev
force-pushed
the
aes_gcm_small_armasm_fix
branch
from
d1e4885 to
41aae56
Compare
dgarske
approved these changes
Apr 9, 2026
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Non-neon GCM_gmult_len requires M0 which is not available with a small build.
Fix to have C implementation when M0 and NEON not available.
Fixes zd#21391
Testing
Regression tested GCM_SMALL builds with armasm