wc_port: guard stddef header include.#10280
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Apr 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates wolfCrypt’s portability headers to avoid including the userland stddef.h header in FreeBSD kernel module builds by introducing a NO_STDDEF_H guard, matching the existing NO_*_H patterns used for kernel-mode configurations.
Changes:
- Guard
#include <stddef.h>inwc_port.hbehind#ifndef NO_STDDEF_H. - Define
NO_STDDEF_HforWOLFSSL_BSDKM(FreeBSD kernel module) builds insettings.h.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wolfssl/wolfcrypt/wc_port.h | Adds NO_STDDEF_H guard around stddef.h include used for size_t in wolfSSL_strnstr declaration. |
| wolfssl/wolfcrypt/settings.h | Defines NO_STDDEF_H in the WOLFSSL_BSDKM configuration block to disable userland stddef.h in FreeBSD kernel builds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Contributor
Author
|
Retest this please. (something with ocsp responder test in generic config test). |
douzzer
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Guard
#include <stddef.h>behind#ifndef NO_STDDEF_H.stddef header is not appropriate for FreeBSD kernel builds.
This is similar to existing pattern for
NO_STRING_H,NO_STDLIB_H, etc.