20260424-fixes#10308
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10308
Scan targets checked: linuxkm-bugs, linuxkm-src
No new issues found in the changed files. ✅
kaleb-himes
left a comment
There was a problem hiding this comment.
-
configure.ac: I see, replacing the "warn then override attempt to disable drbg at configure time" with "honor the request to disable with a build error", that's actually more in line with historical patterns. Good change.
-
I'm pretty sure WC_MIN_DIGEST_SIZE is defined for lkcapi_ecdsa_glue.c but if not in all cases I could see that causing build issues eventually. Noteworthy but not PR holdup worthy.
-
test_pkcs7.c ~ line 4580 accepts two error conditions now, the original only expected WC_KEY_SIZE_E, could hide a regression someday with the
||logic (what if WC_KEY_SIZE_E never returns in some future PR we'd lose it and not know it). Shifting error codes, note-worthy, not PR hold up worthy.
|
retest this please |
|
note, hostap and OpenVPN test failures appear to be unrelated to this PR (present in |
|
note, this PR contains critical test layer fixes for #9843 |
…_len following pattern of wolfSSL#10131, before calling wc_ecc_verify_hash(), for defense-in-depth.
…c_PKCS7_DecodeEnvelopedData() in WOLFSSL_SP_MATH build, allow failure with either WC_KEY_SIZE_E or BUFFER_E, to accommodate blinding added by wolfSSL#10128 / 589feab.
…est() and srp_test() prototypes to avoid -Wunused-function in --enable-sp-math builds.
* add "-Wnull-dereference" to all existing "-pedantic -Wdeclaration-after-statement" configs; * add an --enable-sp-math config to .github/workflows/pq-all.yml and .github/workflows/multi-arch.yml.
…G_SHA512 in the WC_RNG_BANK_FLAG_NO_VECTOR_OPS test; linuxkm/lkcapi_sha_glue.c: in wc_mix_pool_bytes(), accommodate WOLFSSL_DRBG_SHA512.
…rror=pedantic]" in enum wc_DrbgType.
* allow for fips-dev in v7|ready|dev ENABLED_SHA256_DRBG and ENABLED_SHA512_DRBG setup and change from AC_MSG_WARN to AC_MSG_ERROR if user tries to disable outside fips-dev; * set ENABLED_SHA512_DRBG=no in lean-aesgcm setup; wolfcrypt/test/test.c: suppress concurrency-mt-unsafe in myFipsCb(); .wolfssl_known_macro_extras: fix lexical order.
…etected by armel build); .github/workflows/pq-all.yml: for the --enable-sp-math scenario, --disable-quic (QUIC unit tests fail on that combo); wolfcrypt/test/test.c: add WC_MAYBE_UNUSED to ecdsa_test_deterministic_k_rs(), to fix armel sp-math build.
…_clear_secure_renegotiation() with --enable-all CFLAGS=-Og.
…ios missed in the first pass.
…and WOLFSSL_NOSHA512_256;
wolfssl/wolfcrypt/hash.h: when WOLFSSL_NOSHA512_{224,256}, gate out prototypes for wc_Sha512_{224,256}Hash[_ex](), to shift build failures from link-time to compile-time.
linuxkm/lkcapi_ecdsa_glue.c: inkm_ecdsa_verify(), add checks onhash_lenfollowing pattern of #10131, before callingwc_ecc_verify_hash(), for defense-in-depth.tests/api.c: fix-Wnull-dereferences inwolfSSL_UseSecureRenegotiation().tests/api/test_pkcs7.c: intest_wc_PKCS7_BER(), in expected-failurewc_PKCS7_DecodeEnvelopedData()inWOLFSSL_SP_MATHbuild, allow failure with eitherWC_KEY_SIZE_EorBUFFER_E, to accommodate blinding added by #10128 / 589feab.wolfcrypt/test/test.candwolfcrypt/test/test.h: fix gating fordsa_test()andsrp_test()prototypes to avoid-Wunused-functionin--enable-sp-mathbuilds..github/workflows/:-Wnull-dereferenceto all existing-pedantic -Wdeclaration-after-statementconfigs;--enable-sp-mathconfig to.github/workflows/pq-all.ymland.github/workflows/multi-arch.yml.wolfcrypt/test/test.c: inrandom_bank_test(), accommodateWOLFSSL_DRBG_SHA512in theWC_RNG_BANK_FLAG_NO_VECTOR_OPStest;linuxkm/lkcapi_sha_glue.c: inwc_mix_pool_bytes(), accommodateWOLFSSL_DRBG_SHA512.wolfssl/wolfcrypt/random.h: fix "comma at end of enumerator list [-Werror=pedantic]" inenum wc_DrbgType.configure.ac:v7|ready|devENABLED_SHA256_DRBGandENABLED_SHA512_DRBGsetup, and change fromAC_MSG_WARNtoAC_MSG_ERRORif user tries to disable outside fips-dev;ENABLED_SHA512_DRBG=noin lean-aesgcm setup;wolfcrypt/test/test.c: suppressconcurrency-mt-unsafeinmyFipsCb();.wolfssl_known_macro_extras: fix lexical order.tested with