20260426-fixes#10324
Merged
dgarske merged 6 commits intowolfSSL:masterfrom Apr 27, 2026
Merged
Conversation
* fix smallstackcache memory leaks in sha256 and sha512 contexts -- don't init or copy over a context that's been inited but not freed, and make sure to explicitly free any context that's been inited or copied over. * fix uninited-var warnings in slhdsakey_wots_sign(), slhdsakey_xmss_sign(), and slhdsakey_fors_sign() (the uninited-var scenario depends on corrupt arg(s) resulting in zero iterations).
* fix aes_eax_test() for NO_MALLOC (use WC_*_VAR() to allocate eax context). * in slhdsa_test(), gate the profusely verbose TestDumpData() clauses on WC_SLHDSA_VERBOSE_DEBUG.
…REGISTERS handling in bench_stats_ops_finish().
* add workaround in Hash512_df() for gcc compiler bug around AVX512 and object alignment. * add missing WC_VERBOSE_RNG clause.
…56 in wc_LmsParamsMap wc_lms_map[].
…documented __USE_GNU gating on call to accept4() (pre-includes can bring in socket.h before the override setting of _GNU_SOURCE at the top). Also enable accept4() for FreeBSD.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10324
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
Contributor
Author
|
retest this please |
Contributor
Author
|
note all workflow failures on this PR are unrelated to this PR -- unmet edit: and |
dgarske
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfcrypt/src/wc_slhdsa.c:slhdsakey_wots_sign(),slhdsakey_xmss_sign(), andslhdsakey_fors_sign()(the uninited-var scenario depends on corrupt arg(s) resulting in zero iterations).wolfcrypt/test/test.c:aes_eax_test()forNO_MALLOC(useWC_*_VAR()to allocateeaxcontext).slhdsa_test(), gate the profusely verboseTestDumpData()clauses onWC_SLHDSA_VERBOSE_DEBUG.wolfcrypt/benchmark/benchmark.c: add missingWOLFSSL_USE_SAVE_VECTOR_REGISTERShandling inbench_stats_ops_finish().wolfcrypt/src/random.c:Hash512_df()for gcc compiler bug around AVX512 and object alignment.WC_VERBOSE_RNGclause.wolfcrypt/src/wc_lms.c: remove redundant gating onWOLFSSL_LMS_SHAKE256inwc_LmsParamsMap wc_lms_map[].wolfcrypt/src/wc_port.c: inwc_socket_cloexec(), add necessary but undocumented__USE_GNUgating on call toaccept4()(pre-includes can bring insocket.hbefore the override setting of_GNU_SOURCEat the top). Also enableaccept4()for FreeBSD.detected by and tested with