20260428-SLHDSA-fixes#10345
Merged
Frauschi merged 1 commit intowolfSSL:masterfrom Apr 29, 2026
Merged
Conversation
wolfssl/wolfcrypt/wc_slhdsa.h: implement WOLFSSL_SLHDSA_NO_SHAKE and WOLFSSL_SLHDSA_NO_SHA2, and fix WC_SLHDSA_MAX_SIG_LEN setup to reflect SHA2 variants; wolfssl/wolfcrypt/settings.h: if WOLFSSL_KERNEL_MODE, set WOLFSSL_SLHDSA_VERIFY_ONLY unless WOLFSSL_SLHDSA_NO_VERIFY_ONLY; wolfcrypt/src/wc_slhdsa.c: fix WOLFSSL_SLHDSA_VERIFY_ONLY to work with --enable-slhdsa=sha2,verifyonly; fix -Wunused-variables in slhdsakey_wots_pk_from_sig_x4(); wolfcrypt/test/test.c: in slhdsa_test(), fix gating for compatibility with --enable-slhdsa=sha2,verifyonly; tests/api/test_slhdsa.c: fix gating in test_wc_slhdsa() and test_wc_slhdsa_sizes().
douzzer
requested review from
SparkiDev,
philljj,
wolfSSL-Bot and
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10345
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
No new issues found in the changed files. ✅
|
Frauschi
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes for SLH-DSA verifyonly:
wolfssl/wolfcrypt/wc_slhdsa.h: implementWOLFSSL_SLHDSA_NO_SHAKEandWOLFSSL_SLHDSA_NO_SHA2, and fixWC_SLHDSA_MAX_SIG_LENsetup to reflect SHA2 variants;wolfssl/wolfcrypt/settings.h: ifWOLFSSL_KERNEL_MODE, setWOLFSSL_SLHDSA_VERIFY_ONLYunlessWOLFSSL_SLHDSA_NO_VERIFY_ONLY;wolfcrypt/src/wc_slhdsa.c: fixWOLFSSL_SLHDSA_VERIFY_ONLYto work with--enable-slhdsa=sha2,verifyonly;fix
-Wunused-variablesinslhdsakey_wots_pk_from_sig_x4();wolfcrypt/test/test.c: inslhdsa_test(), fix gating for compatibility with--enable-slhdsa=sha2,verifyonly;tests/api/test_slhdsa.c: fix gating intest_wc_slhdsa()andtest_wc_slhdsa_sizes().