ML-KEM: fix AVX2 assembly#10430
Merged
Merged
Conversation
Contributor
Author
|
Code generated with scripts in PR: |
Contributor
Author
|
Jenkins: retest this please |
|
SparkiDev
force-pushed
the
mlkem_avx2_fixes
branch
from
7fb1ced to
ad45b5e
Compare
Contributor
Author
|
Jenkins: retest this please |
AVX2 not decompressing 5-bit values correctly. AVX2 not comparing last 32 bytes of ciphertext. Protect mlkemkey_get_k to only be compiled when make key is compiled in.
SparkiDev
force-pushed
the
mlkem_avx2_fixes
branch
from
ad45b5e to
3c94232
Compare
dgarske
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AVX2 not decompressing 5-bit values correctly.
AVX2 not comparing last 32 bytes of ciphertext.
Protect mlkemkey_get_k to only be compiled when make key is compiled in.
Fixes zd#21471
Testing
Fuzz test.