Fix in ECC point conversion#10445
Open
embhorn wants to merge 2 commits intowolfSSL:masterfrom
Open
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10445
Scan targets checked: wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Tightens ECC point hex parsing to prevent out-of-bounds writes/reads in wolfSSL_EC_POINT_hex2point() and adds regression tests around malformed encodings.
Changes:
- Add bounds checks for curve byte size (
key_sz) and enforce exact expected hex lengths. - Validate compressed point parity prefix (
02/03) and reject undersized/oversized payloads. - Add regression tests for oversized/truncated/partial point encodings and a compressed round-trip parity check.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/api/test_ossl_ec.c | Adds regression tests to ensure malformed EC point hex is rejected and parity handling is correct. |
| src/pk_ec.c | Adds strict length/bounds validation for uncompressed and compressed EC point hex decoding. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
wolfSSL_EC_POINT_hex2pointto validate paramsFixes zd21742
Testing
Added tests in
test_wolfSSL_EC_POINTChecklist