Add TROPIC01 simulator#10449
Open
LinuxJedi wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds CI coverage for the TROPIC01 software simulator and updates the TROPIC01 crypto callback implementation to fix simulator/tooling build issues around secure zeroization.
Changes:
- Upstreams the simulator’s
ForceZero→wc_ForceZeropatch intotropic01.c. - Adds a new GitHub Actions workflow that builds the TROPIC01 simulator Docker image using the PR’s wolfSSL checkout and runs the simulator-backed tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
wolfcrypt/src/port/tropicsquare/tropic01.c |
Replaces ForceZero() calls with wc_ForceZero() for key/IV/private-key cleanup in the TROPIC01 CryptoCb path. |
.github/workflows/tropic01-sim.yml |
New CI workflow to build/run the TROPIC01 simulator integration test image against a pinned wolfSSL/simulators commit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Also fix issues compiling the TROPIC01 support.
|
Member
Author
|
Jenkins restest the please, FIPS test fixed |
Contributor
|
Jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix issues compiling the TROPIC01 support.