asn: fix GetShortInt for asn original.#10458
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes DER INTEGER decoding behavior in GetShortInt() so that a zero-length INTEGER is treated as invalid (returns ASN_PARSE_E) when using the “original” ASN implementation, aligning behavior with GetASN_Integer() and adding a regression test (zd#21783).
Changes:
- Add a
len == 0check inGetShortInt()(non-template/original ASN path) to returnASN_PARSE_Eunder the same FIPS/selftest gating used byGetASN_Integer(). - Add a unit test ensuring a zero-length ASN.1 INTEGER triggers
ASN_PARSE_EforGetShortInt()(with matching FIPS/selftest gating).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
wolfcrypt/src/asn.c |
Rejects zero-length ASN.1 INTEGERs in GetShortInt() (original ASN path) to match strict INTEGER validation behavior. |
tests/api/test_asn.c |
Adds a regression test for zero-length INTEGER handling in GetShortInt(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Contributor
Author
|
Retest this please. |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10458
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
No new issues found in the changed files. ✅
SparkiDev
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
GetShortInt()to return ASN_PARSE_E for zero length with asn=original.Fixes zd#21783.
Testing