ci: skip workflows on draft PRs and rerun on ready_for_review#10506
Closed
aidangarske wants to merge 2 commits into
Closed
ci: skip workflows on draft PRs and rerun on ready_for_review#10506aidangarske wants to merge 2 commits into
aidangarske wants to merge 2 commits into
Conversation
Add a per-job draft-PR guard and the `ready_for_review` trigger type to
every workflow with a `pull_request:` trigger so CI does not run while
a PR is a draft and fires automatically when the PR is marked ready.
Push and repository_dispatch behavior is unchanged.
Most jobs in the wolfssl workflows already had:
if: github.repository_owner == 'wolfssl'
The new guard composes with that condition rather than replacing it, so
fork-skip semantics on non-wolfssl pushes are preserved:
if: >-
github.repository_owner == 'wolfssl' &&
(github.event_name != 'pull_request' ||
github.event.pull_request.draft == false)
The wider `github.event_name != 'pull_request' || ...` form is used
(rather than a bare `draft == false` check) so the rationale is explicit
and not dependent on GitHub Actions' loose-equality coercion behavior
on push/repository_dispatch events.
Adds a workflow-level concurrency block to the five workflows that
didn't already have one (ada, cmake, cmake-autoconf, threadx,
win-csharp-test) so superseded in-flight runs are cancelled by newer
commits on the same PR/branch.
Workflows NOT touched: coverity-scan-fixes, membrowse-comment,
membrowse-onboard, tls-anvil. None of these have a pull_request
trigger.
The initial patch missed docker-OpenWrt.yml because its jobs are indented with 4 spaces instead of the 2-space convention used by every other workflow. Compose the draft guard with the existing owner gate on both jobs at the file's actual indent.
|
Member
Author
|
close in favor of #10507 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description