Skip to content

bsdkm: misc cleanup.#10565

Merged
douzzer merged 2 commits into
wolfSSL:masterfrom
philljj:bsdkm_misc_cleanup
Jun 5, 2026
Merged

bsdkm: misc cleanup.#10565
douzzer merged 2 commits into
wolfSSL:masterfrom
philljj:bsdkm_misc_cleanup

Conversation

@philljj
Copy link
Copy Markdown
Contributor

@philljj philljj commented Jun 1, 2026

Description

Some bsdkm cleanup. Fixes Fenrir issues, and tidies up some loose ends.

@philljj philljj self-assigned this Jun 1, 2026
Copilot AI review requested due to automatic review settings June 1, 2026 05:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs small cleanup and correctness fixes in the FreeBSD kernel module (“bsdkm”) integration, aimed at addressing reported issues (Fenrir) and tightening teardown/cleanup behavior.

Changes:

  • Add NULL-guard checks for the per-CPU FPU state array in x86 vector-register save/restore helpers.
  • Adjust attach/detach error handling and add more explicit error logging in the crypto driver glue.
  • Fix an AES-GCM self-test buffer initialization bug and zeroize additional sensitive state on exit paths.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
bsdkm/x86_vecreg.c Adds fpu_states NULL checks in vecreg save/restore paths.
bsdkm/wolfkmod.c Tweaks attach/detach cleanup/unregister flow; adds extra zeroization and error normalization in CBC/GCM work functions.
bsdkm/wolfkmod_aes.c Fixes incorrect size used when clearing resultC2 in AES-GCM test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread bsdkm/wolfkmod.c
Comment thread bsdkm/wolfkmod.c
Comment thread bsdkm/x86_vecreg.c
Comment thread bsdkm/x86_vecreg.c
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 1, 2026

MemBrowse Memory Report

gcc-arm-cortex-m4

  • FLASH: .text +384 B (+0.2%, 197,934 B / 262,144 B, total: 76% used)
  • RAM: .bss +8 B (+1.0%, 836 B / 65,536 B, total: 1% used)

gcc-arm-cortex-m4-baremetal

  • FLASH: .text +832 B (+1.3%, 65,739 B / 262,144 B, total: 25% used)
  • RAM: .bss +36 B (+5.6%, 680 B / 65,536 B, total: 1% used)

gcc-arm-cortex-m4-min-ecc

  • FLASH: .text +384 B (+0.5%, 60,717 B / 262,144 B, total: 23% used)
  • RAM: .bss +8 B (+1.2%, 676 B / 65,536 B, total: 1% used)

gcc-arm-cortex-m4-tls12

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

Comment thread bsdkm/wolfkmod.c
@philljj philljj assigned wolfSSL-Bot and unassigned philljj Jun 5, 2026
@douzzer douzzer merged commit 1d93484 into wolfSSL:master Jun 5, 2026
470 of 475 checks passed
@philljj philljj deleted the bsdkm_misc_cleanup branch June 5, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants