refactor decrypt content with PKCS12 and fix for AES-256 + HMAC SHA25…#2868
Merged
toddouska merged 1 commit intowolfSSL:masterfrom Mar 25, 2020
Merged
refactor decrypt content with PKCS12 and fix for AES-256 + HMAC SHA25…#2868toddouska merged 1 commit intowolfSSL:masterfrom
toddouska merged 1 commit intowolfSSL:masterfrom
Conversation
dgarske
approved these changes
Mar 25, 2020
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Thanks Jacob! Awesome work on this and thank you for updating/fixing the example (wolfSSL/wolfssl-examples#192)
| } | ||
|
|
||
| ret = wc_CryptKey(password, passwordSz, salt, saltSz, iterations, id, | ||
| input + inOutIdx, length, version, cbcIv, 0, 0); |
Member
There was a problem hiding this comment.
For reference the bug was here on the last arg of wc_CryptKey call, which was not providing shaOid on the last arg.
toddouska
approved these changes
Mar 25, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZD 9972