Fix for OCSP response in non-blocking mode and testing script improvements#3204
Merged
toddouska merged 3 commits intowolfSSL:masterfrom Sep 1, 2020
Merged
Fix for OCSP response in non-blocking mode and testing script improvements#3204toddouska merged 3 commits intowolfSSL:masterfrom
toddouska merged 3 commits intowolfSSL:masterfrom
Conversation
toddouska
reviewed
Aug 10, 2020
Contributor
There was a problem hiding this comment.
Does LastError() return errno on most systems now which wouldn't match SOCKET_EWOULDBLOCK?
Member
Author
There was a problem hiding this comment.
I'm open to change this, but this is copy/paste from the existing EmbedReceive, EmbedSend, EmbedReceiveFrom and EmbedSendTo.
Contributor
There was a problem hiding this comment.
Don't we usually test against SOCKET_EAGAIN as well?
Contributor
There was a problem hiding this comment.
Does requiring the user to turn on nonblocking support make sense? That is, isn't that usually the default in wolfSSL.
…nabled (use `-b` bind to any on server). Fix to use random port number for the `oscp-stapling.test` script. Reduce delay times in scripts.
dgarske
changed the title
Member
Author
|
retest this please |
kaleb-himes
approved these changes
Aug 28, 2020
Contributor
kaleb-himes
left a comment
kaleb-himes
left a comment
There was a problem hiding this comment.
Changes in the script look good, thanks David! Over to Todd.
toddouska
approved these changes
Sep 1, 2020
TakayukiMatsuo
pushed a commit
to TakayukiMatsuo/wolfssl
that referenced
this pull request
Feb 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-bbind to any on server).oscp-stapling.testscript.Example: wolfSSL/wolfssl-examples#224
ZD 10417