PKCS #11: implement identifying keys by label #3416
Closed
SparkiDev wants to merge 5 commits intowolfSSL:masterfrom
Closed
PKCS #11: implement identifying keys by label #3416SparkiDev wants to merge 5 commits intowolfSSL:masterfrom
SparkiDev wants to merge 5 commits intowolfSSL:masterfrom
Conversation
SparkiDev
force-pushed
the
pkcs11_label
branch
4 times, most recently
from
80505b9 to
013dba2
Compare
Check private key matches the public key passed in. Need to use a new API to pass in the token to use to perform PKCS wolfSSL#11 operations with.
SparkiDev
force-pushed
the
pkcs11_label
branch
from
013dba2 to
a49d901
Compare
fencekicker
reviewed
Nov 4, 2020
| *pkey = (void*)rsaKey; | ||
| } | ||
| else { | ||
| XFREE(rsaKey, heap, DYNAMIC_TYPE_EC); |
There was a problem hiding this comment.
Shouldn't this be DYNAMIC_TYPE_RSA?
fencekicker
reviewed
Nov 4, 2020
| *pkey = (void*)ecKey; | ||
| } | ||
| else { | ||
| XFREE(ecKey, heap, DYNAMIC_TYPE_EC); |
SparkiDev
force-pushed
the
pkcs11_label
branch
from
3972f5c to
9ddc799
Compare
…gn for RSA Was opening and closing sessions when operations not compiled in were being attempted (e.g. hashing during certificate signing). C_Sign can be used with X509 RSA (raw) as it does the same operations as C_Decrypt. Use the function matching hig level operation where supported. Make debugging functions take a CK_ULONG rather than an int - to avoid casting.
Contributor
Author
|
New branch on which these changes have been applied to current master: This pull request closed and maintained for customer. They are using 4.3.0 so differences doesn't apply easily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.