Allow SHA1 with NO_OLD_TLS#4793
Closed
embhorn wants to merge 1 commit intowolfSSL:masterfrom
Closed
Conversation
dgarske
approved these changes
Jan 25, 2022
embhorn
force-pushed
the
gh4791
branch
2 times, most recently
from
3c2a15f to
02948a2
Compare
dgarske
requested changes
Jun 1, 2022
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Please setup a test case to reproduce. Consider adding a test case. Consider not enabling the MD5 code with WOLFSSL_ALLOW_TLS_SHA1.
|
Can one of the admins verify this patch? |
Member
Author
|
Fixed by #7070 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add conditional for
WOLFSSL_ALLOW_TLS_SHA1with!NO_OLD_TLSFixes #4791
Testing
Built with
./configure --disable-oldtls -- CFLAGS="-DWOLFSSL_ALLOW_TLS_SHA1"