Remove FIPS preprocessor defines from Windows build options#5587
Merged
ejohnstown merged 1 commit intowolfSSL:masterfrom Sep 13, 2022
Merged
Conversation
…ons (values specified via user_settings.h)
tim-weller-wolfssl
assigned
tim-weller-wolfssl and
JacobBarthelmeh and unassigned
tim-weller-wolfssl
JacobBarthelmeh
approved these changes
Sep 13, 2022
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Looks good to me, I'd like @ejohnstown to take a look since this is removing the HAVE_FIPS_VERSION macros from the project.
ejohnstown
approved these changes
Sep 13, 2022
Contributor
|
The change makes sense. I'm wondering why I didn't do that when I was last in those files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove FIPS preprocessor defines from Windows build command-line options (values specified via user_settings.h)
Testing
Tested in Windows 11 environment using Visual Studio 2022 with wolfEngine.