Async Sniffer: Fix for decryption after second handshake#5811
Merged
dgarske merged 2 commits intowolfSSL:masterfrom Dec 12, 2022
Merged
Async Sniffer: Fix for decryption after second handshake#5811dgarske merged 2 commits intowolfSSL:masterfrom
dgarske merged 2 commits intowolfSSL:masterfrom
Conversation
dgarske
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an infinite loop that can occur after a second handshake after initial decryption.
wolfSSL_Async_Push()inSetupKeys()doesn't get towolfSSL_Async_Pop()inSetupKeys(), instead it is popped atDecryptTls()causing an infinite loop.Fixes zd#15184
Testing
How did you test?
On QAT hardware with the testfiles provided by customer.
Checklist