SP int: fix when ECC specific size code included#5849
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Dec 6, 2022
Merged
Conversation
Was enabled when !SP and HAVE_ECC Now enabled when !WOLFSSL_SP_MATH and HAVE_ECC
SparkiDev
force-pushed
the
sp_int_sp_ecc_fix
branch
from
f6b8cd4 to
6db2ea0
Compare
dgarske
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Was enabled when !SP and HAVE_ECC
Now enabled when !WOLFSSL_SP_MATH and HAVE_ECC
Testing
Compared benchmark of Brainpool curves when:
./configure '--disable-shared' '--enable-brainpool' '--enable-ecccustcurves'
./configure '--disable-shared' '--enable-brainpool' '--enable-ecccustcurves' --enable-sp=yes,asm
Checklist