SP: --enable-sp-asm now enables SP if not set#5851
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Dec 7, 2022
Merged
Conversation
SparkiDev
force-pushed
the
sp_enable_asm_fix
branch
2 times, most recently
from
de3c55c to
5cf4025
Compare
dgarske
requested changes
Dec 6, 2022
Member
There was a problem hiding this comment.
I do not see the corresponding XFREE? Is DYNAMIC_TYPE_ECC the right type?
Enabling SP with ASM didn't enable SP or error out when SP wasn't configured. Now enables SP when '' and errors when 'no'. SAKKE modinv used large amounts of stack. Change to have more temporary memory allocated increased to cover the usage. ECC, SAKKE: sp_<bits>_ecc_mulmod_<cpu><words>() used large amounts of stack. Allocate when WOLFSSL_SMALL_STACK. wc_DhCheckKeyPair() not available when HAVE_SELFTEST. Wasn't compiled in before as WOLFSSL_HAVE_SP_DH wasn't defined.
SparkiDev
force-pushed
the
sp_enable_asm_fix
branch
from
5cf4025 to
1de30c6
Compare
Contributor
Author
|
After fix, with: |
dgarske
approved these changes
Dec 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enabling SP with ASM didn't enable SP or error out when SP wasn't configured. Now enables SP when '' and errors when 'no'.
Testing
./configure --enable-sp-asm
./configure --enable-sp-asm --enable-sp=no
./configure --enable-sp-asm --disable-sp
Checklist