Skip to content

Fixups for problems discovered while testing for DTLS 1.3#5858

Merged
dgarske merged 1 commit intowolfSSL:masterfrom
anhu:dtls13_fixups
Dec 6, 2022
Merged

Fixups for problems discovered while testing for DTLS 1.3#5858
dgarske merged 1 commit intowolfSSL:masterfrom
anhu:dtls13_fixups

Conversation

@anhu
Copy link
Copy Markdown
Member

@anhu anhu commented Dec 6, 2022

The problems were found with the following configurations:

./configure --enable-dtls --enable-dtls13 CFLAGS="-DNO_WOLFSSL_CLIENT"
./configure --enable-dtls --enable-dtls13 CFLAGS="-DNO_WOLFSSL_SERVER"
./configure --enable-tls13 --disable-oldtls --enable-static --enable-singlethreaded --enable-dtls --enable-dtls13 --enable-sp=yes,4096 --disable-shared --enable-dtls-mtu --disable-sha3 --disable-dh --enable-curve25519 --enable-secure-renegotiation C_EXTRA_FLAGS="-DWOLFSSL_DTLS_ALLOW_FUTURE -DWOLFSSL_MIN_RSA_BITS=2048 -DWOLFSSL_MIN_ECC_BITS=256 -DFP_MAX_BITS=8192 -fomit-frame-pointer"

@anhu anhu requested review from dgarske and rizlik December 6, 2022 16:37
@anhu anhu assigned dgarske and anhu and unassigned dgarske Dec 6, 2022
@dgarske
Copy link
Copy Markdown
Member

dgarske commented Dec 6, 2022

@anhu please add here what build settings you used to reproduce and make some suggestions for new PRB test cases. Seems like we are missing some CI build test cases.

@dgarske dgarske self-assigned this Dec 6, 2022
@anhu
Copy link
Copy Markdown
Member Author

anhu commented Dec 6, 2022

I've been assigned the task of creating new PRB tests for DTLS 1.3 and in the process of creating those tests, I've found these problems. Most of them came from these:

./configure --enable-dtls --enable-dtls13 CFLAGS="-DNO_WOLFSSL_CLIENT"

./configure --enable-dtls --enable-dtls13 CFLAGS="-DNO_WOLFSSL_SERVER"

I've tried about 20 different combinations so far. Can't remember which other ones were broken. I think there was only one more.

Comment thread src/sniffer.c
break;
#ifdef WOLFSSL_DTLS13
case ack:
/* TODO */
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't exactly know what to do here so I put todo... Is fallthrough alright? If so, I can change to fallthrough.
Let me know please.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is fine for the sniffer. Thanks

@dgarske dgarske merged commit 6bde6af into wolfSSL:master Dec 6, 2022
@anhu anhu deleted the dtls13_fixups branch March 24, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants