Fixups for problems discovered while testing for DTLS 1.3#5858
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Dec 6, 2022
Merged
Fixups for problems discovered while testing for DTLS 1.3#5858dgarske merged 1 commit intowolfSSL:masterfrom
dgarske merged 1 commit intowolfSSL:masterfrom
Conversation
dgarske
approved these changes
Dec 6, 2022
rizlik
approved these changes
Dec 6, 2022
Member
|
@anhu please add here what build settings you used to reproduce and make some suggestions for new PRB test cases. Seems like we are missing some CI build test cases. |
Member
Author
|
I've been assigned the task of creating new PRB tests for DTLS 1.3 and in the process of creating those tests, I've found these problems. Most of them came from these: I've tried about 20 different combinations so far. Can't remember which other ones were broken. I think there was only one more. |
anhu
commented
Dec 6, 2022
| break; | ||
| #ifdef WOLFSSL_DTLS13 | ||
| case ack: | ||
| /* TODO */ |
Member
Author
There was a problem hiding this comment.
I didn't exactly know what to do here so I put todo... Is fallthrough alright? If so, I can change to fallthrough.
Let me know please.
Member
There was a problem hiding this comment.
Yes this is fine for the sniffer. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problems were found with the following configurations: