Allow for unknown OIDs in extensions in wolfSSL_X509_set_ext()#6364
Merged
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom May 8, 2023
Merged
Allow for unknown OIDs in extensions in wolfSSL_X509_set_ext()#6364JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom
Conversation
...and add some testing to show we properly inserted the extensions.
Member
Author
|
retest please |
Member
Author
|
jenkins retest this please |
JacobBarthelmeh
requested changes
May 3, 2023
| XFREE(cert, NULL, DYNAMIC_TYPE_DCERT); | ||
| #endif | ||
| return NULL; | ||
| if (ext->obj != NULL) { |
Contributor
There was a problem hiding this comment.
Continuing on without a break if ext->obj is null results in potential null derefrences. An example would be if wolfSSL_OBJ_nid2obj failed and returned null and the case BASIC_CA_OID is used.
Member
Author
There was a problem hiding this comment.
Woah!!! Sharp eye @JacobBarthelmeh !! Thank you very much for spotting that. Its been fixed.
JacobBarthelmeh
approved these changes
May 8, 2023
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Please follow up on this with adding WOLFSSL_CUSTOM_OID to automated CI tests if not already there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...and add some testing to show we properly inserted the extensions.
Testing
Added tests to verify that extensions were inserted properly.
Checklist