always call crypto cb when compiled in#6389
Merged
dgarske merged 5 commits intowolfSSL:masterfrom May 11, 2023
Merged
Conversation
dgarske
approved these changes
May 9, 2023
dgarske
approved these changes
May 9, 2023
dgarske
requested changes
May 10, 2023
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Please wrap with HAVE_CRYPTOCB_FIND_CB as discussed. This will avoid any possible issues with PKCS11/Async.
dgarske
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix cases where a "find device ID" callback is set the code needs to always call down into the crypto callback function. In cases where it is INVALID_DEVID the callback may choose to override it.
ZD 15973