Fix wolfssl_asn1_time_to_tm setting unexpected fields in tm struct.#6403
Merged
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom May 12, 2023
Merged
Fix wolfssl_asn1_time_to_tm setting unexpected fields in tm struct.#6403JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom
Conversation
dgarske
previously approved these changes
May 12, 2023
JacobBarthelmeh
requested changes
May 12, 2023
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Needs a test case added to tests/api.c
Contributor
Author
|
Test added. Unfortunately we can't test for tm_gmtoff as this is not guaranteed to be part of struct tm per POSIX, and there is no preprocessor macro I could find that would gate it. |
JacobBarthelmeh
approved these changes
May 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6387
Testing
Tested and confirmed using provided reproducer.
Checklist