Update EBSNET port#6410
Conversation
|
@dgarske - Sarah has asked me to open this PR on her behalf. I will request approval for the contributor agreement after your cursory review. |
|
retest this please |
|
@dgarske - customer is approved as a contributor. This PR is ready for review. |
There was a problem hiding this comment.
We should not assume RTPLATFORM is always defined. Should this be #if defined(HAVE_RTP_SYS) || defined(RTPLATFORM). Otherwise if RTPLATFORM is not defined it will be a compiler error. If RTPLATFORM is also an expression like RTPLATFORM != 0 please add it explicit.
There was a problem hiding this comment.
Also here. Please check that it is defined.
There was a problem hiding this comment.
You missed a few places where RTPLATFORM is used without checking if defined. Perhaps it is safe to assume if EBSNET is defined that RTPLATFORM is always defined?
There was a problem hiding this comment.
Also here. Make sure 4 spaces and no tabs.
There was a problem hiding this comment.
Bring function ident back to align with strcasecmp?
There was a problem hiding this comment.
I think the ident on all functions in this group should be 4 spaces back.
|
Retest this please |
2 participants
Description
Updates to EBSNET port
Author: Sarah Richardson
Fixes zd15856
Testing
Customer tested
Checklist