scan-build fixes#6427
Merged
bandi13 merged 1 commit intowolfSSL:masterfrom May 19, 2023
Merged
Conversation
sp_mulmod - scan-build getting confused with size of result - don't check result size as checked already - split out implementation of sp_mulmod from check StoreEccKey - ensure pubKey is not NULL even though all uses will not be GetCertKey - ensure source is not NULL - cert->source may be NULL in incorrect usages of APIs
bandi13
approved these changes
May 19, 2023
Contributor
bandi13
left a comment
bandi13
left a comment
There was a problem hiding this comment.
Tested locally and seems to resolve issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sp_mulmod
StoreEccKey
GetCertKey
Testing
./configure --disable-shared CC=clang
scan-build-10 make
Checklist