ASN: fix so that NO_CERTS configurations work#6551
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Jul 3, 2023
Merged
Conversation
SparkiDev
force-pushed
the
asn_no_certs
branch
3 times, most recently
from
e77efd1 to
5022451
Compare
dgarske
requested changes
Jun 30, 2023
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
The test ./configure cases you provided don't link. Looks like the PKCS12 gets enabled by default on some platforms. Builds fine if I add --disable-pkcs12. Do you want to fix that or should we just update the test description?
./configure --enable-cryptonly CFLAGS=-DNO_CERTS --enable-asn=original && make
CCLD src/libwolfssl.la
Undefined symbols for architecture x86_64:
"_FreeDecodedCert", referenced from:
_wc_PKCS12_parse in src_libwolfssl_la-pkcs12.o
"_InitDecodedCert", referenced from:
_wc_PKCS12_parse in src_libwolfssl_la-pkcs12.o
"_ParseCertRelative", referenced from:
_wc_PKCS12_parse in src_libwolfssl_la-pkcs12.o
Contributor
|
Can you take care of RSA-PSS? The ticket user #16359 uses the option. ./configure CFLAGS=-DNO_CERTS --enable-cryptonly --enable-rsapss --enable-asn=original |
Moved code around and update #ifdefs so that --enable-cryptonly CFLAGS=-DNO_CERTS compiles.
Contributor
Author
|
Fixed all the configuration mentioned above. |
dgarske
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moved code around and update #ifdefs so that --enable-cryptonly CFLAGS=-DNO_CERTS compiles.
Testing
Checklist