Fix compilation of wc_RsaFunctionNonBlock if WOLFSSL_RSA_PUBLIC_ONLY …#6556
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Jul 3, 2023
StMartin81:Fix_compilation_of_wc_RsaFunctionNonBlock_if_WOLFSSL_RSA_PUBLIC_ONLY_is_defined
Merged
Fix compilation of wc_RsaFunctionNonBlock if WOLFSSL_RSA_PUBLIC_ONLY …#6556dgarske merged 1 commit intowolfSSL:masterfrom StMartin81:Fix_compilation_of_wc_RsaFunctionNonBlock_if_WOLFSSL_RSA_PUBLIC_ONLY_is_defined
dgarske merged 1 commit intowolfSSL:masterfrom
StMartin81:Fix_compilation_of_wc_RsaFunctionNonBlock_if_WOLFSSL_RSA_PUBLIC_ONLY_is_defined
Conversation
|
Can one of the admins verify this patch? |
Member
|
Thank you @StMartin81 for the fix! Contributor agreement on file. OK to test. |
dgarske
approved these changes
Jun 29, 2023
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Thank you @StMartin81 , this is the correct fix. This matches the pattern used in the normal synchronous software case and fixes the build to allow public only. The CI failure is internal issue with our FIPS tests (we will resolve and retry).
./configure --enable-fastmath CFLAGS="-DWC_RSA_NONBLOCK -DWOLFSSL_RSA_PUBLIC_ONLY" --disable-examples --disable-crypttests && make
Member
|
Retest this please |
1 similar comment
Member
|
Retest this please |
Member
|
Retest this please |
Member
|
Retest this please. Our CI/Jenkins is showing different failures unrelated to the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if this patch is correct but when WOLFSSL_RSA_PUBLIC_ONLY is defined the RsaKey struct doesn't contain the "d" field.