Heap Math exptmod: fixes for valid modulus checks#6599
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Jul 12, 2023
Merged
Heap Math exptmod: fixes for valid modulus checks#6599JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
mp_exptmod_base_2() uses Montogmery method and does not support even modulus. Added check. mp_exptmod_fast() uses Montogmery method when odd not when dr > 0. Comment updated at call. Reduce value of zero doesn't work for mp_reduece_2k. Changed setup of use to check for zero and won't use it. Other methods won't work either.
JacobBarthelmeh
approved these changes
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mp_exptmod_base_2() uses Montogmery method and does not support even modulus. Added check.
mp_exptmod_fast() uses Montogmery method when odd not when dr > 0. Comment updated at call.
Reduce value of zero doesn't work for mp_reduece_2k. Changed setup of use to check for zero and won't use it. Other methods won't work either.
Fixes zd#16425
Testing
POC with
./configure --disable-shared --enable-heapmath
Checklist