Add support for MemUse Entropy on Windows.#6612
Merged
SparkiDev merged 2 commits intowolfSSL:masterfrom Jul 14, 2023
Merged
Conversation
Member
Author
|
This PR adds a precision timer for Windows, but it should not cause this error, which leads me to suspect there could be an underlying issue: @SparkiDev or @tmael can you please review this error: https://cloud.wolfssl-test.com/jenkins/job/PRB-generic-config-parser/1730/consoleFull ? |
tmael
reviewed
Jul 13, 2023
|
|
||
| QueryPerformanceCounter(&count); | ||
|
|
||
| return (word64)(count.QuadPart / (freq.QuadPart / 1000 / 1000)); |
Contributor
There was a problem hiding this comment.
The comment indicates nanoseconds, but the returned value is in microseconds.
divide by another / 1000
or I think you can use
(word64)(count.QuadPart / freq.QuadPart * 1000000000);
tmael
reviewed
Jul 13, 2023
SparkiDev
previously approved these changes
Jul 13, 2023
…mer to differentiate, not specific time.
SparkiDev
approved these changes
Jul 13, 2023
tmael
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for MemUse Entropy on Windows
ZD 16422
Testing
Tested with on Windows 10 with our Visual Studio project. Adding these options to the user_settings.h:
Checklist