Skip to content

Add in PKIXSSH#6621

Merged
JacobBarthelmeh merged 6 commits intowolfSSL:masterfrom
bandi13:addPKIXSSH
Aug 14, 2023
Merged

Add in PKIXSSH#6621
JacobBarthelmeh merged 6 commits intowolfSSL:masterfrom
bandi13:addPKIXSSH

Conversation

@bandi13
Copy link
Copy Markdown
Contributor

@bandi13 bandi13 commented Jul 14, 2023

No description provided.

@bandi13 bandi13 requested a review from dgarske July 14, 2023 16:19
@dgarske dgarske requested review from JacobBarthelmeh and removed request for dgarske July 14, 2023 16:30
@dgarske dgarske assigned JacobBarthelmeh and bandi13 and unassigned dgarske Jul 14, 2023
Copy link
Copy Markdown
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the readme in the Docker directory if merging in this change. The Dockerfile is changing from a simple, just wolfSSL, to a test all Dockerfile. Alternatively we could remove the third party library installs bundled with wolfSSL and maintain a test Dockerfile in the testing repo?

@bandi13
Copy link
Copy Markdown
Contributor Author

bandi13 commented Aug 14, 2023

Please update the readme in the Docker directory if merging in this change. The Dockerfile is changing from a simple, just wolfSSL, to a test all Dockerfile. Alternatively we could remove the third party library installs bundled with wolfSSL and maintain a test Dockerfile in the testing repo?

I'm trying to keep the Dockerfile in sync with our testing VM image. I use this Docker image for development as well. I've modified the README.md as requested. It's better to have this Dockerfile exposed to anyone to use instead of putting it in the private testing repo.

@bandi13
Copy link
Copy Markdown
Contributor Author

bandi13 commented Aug 14, 2023

retest this please

@bandi13 bandi13 removed their assignment Aug 14, 2023
@JacobBarthelmeh JacobBarthelmeh merged commit bbcd91b into wolfSSL:master Aug 14, 2023
@bandi13 bandi13 deleted the addPKIXSSH branch September 28, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants