Fix benchmark failure on FIPS builds#6623
Merged
dgarske merged 3 commits intowolfSSL:masterfrom May 20, 2024
Merged
Conversation
JacobBarthelmeh
previously approved these changes
Jul 20, 2023
Member
|
Retest this please |
Member
|
Retest this please |
dgarske
force-pushed
the
FIPS-TLS-benchmark-CAST-fix
branch
from
64df3bb to
e823da9
Compare
Member
|
Can't seem to get it to re-test or pass this macOS check in GitHub CI. I went ahead and rebased and force pushed. Let's see if we still get a failure. |
dgarske
previously approved these changes
May 17, 2024
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
@kaleb-himes please finalize and merge if you are happy.
SparkiDev
reviewed
May 19, 2024
| int ret = 0; | ||
| int cast_idx = 0; | ||
|
|
||
| for (cast_idx=0; cast_idx<FIPS_CAST_COUNT; cast_idx++) { |
Contributor
There was a problem hiding this comment.
Should have spaces around '=' and '<'.
Contributor
Author
There was a problem hiding this comment.
fixed in latest commit. @dgarske thank you for bringing this PR back from the dead!!
dgarske
approved these changes
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug where
tls_benchcan fail on FIPS builds in a multithreaded environment because of simultaneous attempts by client and server threads to run a CAST on-the-fly during the TLS handshake. This usually manifests itself as a KAT failure in ECC or AES, though I have seen a few other spurious error messages pop up depending on timing.Bug reproduction
Try and run
tls_benchon a multithreaded system onmasterand it should fail and report a KAT failure. Running on this branch should resolve the issue.