Dtls13GetRnMask: Correctly get chacha counter on BE systems#6641
Merged
JacobBarthelmeh merged 4 commits intowolfSSL:masterfrom Jul 26, 2023
Merged
Dtls13GetRnMask: Correctly get chacha counter on BE systems#6641JacobBarthelmeh merged 4 commits intowolfSSL:masterfrom
JacobBarthelmeh merged 4 commits intowolfSSL:masterfrom
Conversation
rizlik
requested changes
Jul 24, 2023
The issue was that BIG_ENDIAN is defined in endian.h (on linux). Our define is BIG_ENDIAN_ORDER.
rizlik
previously approved these changes
Jul 24, 2023
JacobBarthelmeh
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was that BIG_ENDIAN is defined in endian.h (on linux). Our define is BIG_ENDIAN_ORDER.
Tested on a big endian Debian running on qemu-system-mips.
Fixes issue reported in #6555.