DTLS downgrade bug fixes#6668
Merged
SparkiDev merged 4 commits intowolfSSL:masterfrom Aug 3, 2023
Merged
Conversation
Member
julek-wolfssl
commented
Aug 1, 2023
julek-wolfssl
commented
- DtlsShouldDrop: don't ignore app data sent before a SCR handshake
- Require HAVE_SECURE_RENEGOTIATION for API that perform SCR (not just indication)
- Add logging prefixes to api.c client and server
julek-wolfssl
force-pushed
the
zd/16515
branch
2 times, most recently
from
9d27092 to
c6b871b
Compare
Member
Author
|
retest this please |
Contributor
|
ZD16515? |
JacobBarthelmeh
approved these changes
Aug 3, 2023
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Looks good, would like a second review though where this impacts TLS 1.3 and not only DTLS 1.3 (https://github.com/wolfSSL/wolfssl/pull/6668/files#diff-927d62a3fce45ef1b7d9ba70df049ab4dc21ea53fc2491b5c006fc96c5af680eR11920)
Member
Author
|
Yes this addresses an issue found while working on ZD16515. |
SparkiDev
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.