FIPS Check Update#6674
Merged
JacobBarthelmeh merged 4 commits intowolfSSL:masterfrom Aug 8, 2023
Merged
Conversation
1. Whitespace changes. 2. Deleted the stm32l4 build. The fips-check-2.0.sh script handles it. 3. Removed the CAVP_SELFTEST_* variables, used the FIPS_OPTIONS for it. 4. Removed the v1 style code checkout. The current method works for all available cases. 5. Removed the FIPS_CONFLICTS case rename case.
Contributor
Author
|
This change is intended to make my next change easier. For each build, the files are going to be listed explicitly in tuples with the file revision to be checked out. |
douzzer
previously approved these changes
Aug 4, 2023
|
|
||
| if [ "$1" == "" ]; then FLAVOR="undef"; else FLAVOR="$1"; fi | ||
| while [ "x$1" != 'x' ]; do | ||
| if [ "x$1" = 'xkeep' ]; then KEEP='yes'; else FLAVOR="$1"; fi |
Contributor
There was a problem hiding this comment.
shellcheck says
In fips-check.sh line 42:
if [ "x$1" = 'xkeep' ]; then KEEP='yes'; else FLAVOR="$1"; fi
^---^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose.
Contributor
Author
|
Here's a link to my check script. https://gist.github.com/ejohnstown/0fee1429ef43bb515104e2894940a5f7 |
Contributor
|
retest this please. |
Contributor
Author
|
retest this please |
dgarske
approved these changes
Aug 8, 2023
JacobBarthelmeh
approved these changes
Aug 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Kept a copy of the previous fips-check.sh script pre-byebyecyassl named orig-fips-check.sh. I wrote a script that called both orig-fips-check.sh and this version (which uses a different output directory), and then did a file compare between the wolfcrypt source and header files. I logged the output of the diff. The goal was to have absolutely no changes.
Checklist