Fixes for wolfSSL conditional porting#6686
Merged
JacobBarthelmeh merged 10 commits intowolfSSL:masterfrom Aug 9, 2023
Merged
Conversation
dgarske
commented
Aug 8, 2023
julek-wolfssl
previously requested changes
Aug 8, 2023
Member
julek-wolfssl
left a comment
julek-wolfssl
left a comment
There was a problem hiding this comment.
If there is a dedicated mutex just for the condition stuff then I don't see why lockCount is needed? Also I would be cautious if the variables being set around the signal calls will register in all threads correctly.
…ge situations. Added better signal support on MacOS. Issue created in PR wolfSSL#6437.
Member
Author
|
Might fix: curl/curl#11533 |
dgarske
assigned
JacobBarthelmeh and
wolfSSL-Bot and unassigned
dgarske and
julek-wolfssl
Member
Author
|
Approved. Thanks @julek-wolfssl . Over to @JacobBarthelmeh to finalize. |
JacobBarthelmeh
approved these changes
Aug 9, 2023
JacobBarthelmeh
dismissed
julek-wolfssl’s stale review
old review before multiple changes the next day
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for conditional (signals), which might cause deadlock in high usage situations.
Added better signal support on MacOS.
Issue created in PR #6437.
Testing
How did you test?
Checklist